Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Template: Refactor rendering mode management in editor provider and store to persist it #68257

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Show Template: Refactor rendering mode management in editor provider and store to persist it #68257

wants to merge 1 commit into from
+18 −20

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Dec 24, 2024 •
edited
Loading

Fixes: #68250

What?

Implements Data Persistence into Preferences Store for Show Template.

Why?

Brings an enhancement to the previous implementation, where, the value set by the user for Show Template would get overwritten by subsequent refresh made to the page.

How?

The store has been updated to consider using preferences store to persist this data.

Testing Instructions

  1. Create a new page from the site editor.
  2. Change the value from Show Template toggle.
  3. Refresh, and observe that the value now persists.

Screencast

Screen Recording Dec 24 2024

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review December 24, 2024 08:22
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: annezazu <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Feature] Template Editing Mode Related to the template editor available in the Block Editor labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Template Editing Mode Related to the template editor available in the Block Editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "Show template" option persistent
2 participants
@yogeshbhutkar @Mamaduka